remove deprecated k8s flags support #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonjohnsonjr
approved these changes
Jul 13, 2022
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Aug 30, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
7 tasks
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Aug 30, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Aug 30, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Aug 31, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
7 tasks
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
7 tasks
abayer
added a commit
to abayer/tektoncd-pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
7 tasks
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Sep 6, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot
pushed a commit
to tektoncd/pipeline
that referenced
this pull request
Sep 7, 2022
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned in #748
Support for kubectl flags in
ko applyandko createhas been deprecated since #413 (466dbab), merged Aug 2021, released in v0.9 (Sept 2021).